Wireshark · Wireshark-dev: Re: [Wireshark-dev] Dissector bug

["Maynard, Chris" <Christopher.Maynard@xxxxxxxxx>]

You have some duplicates being registered.

 

grep "hf_" packet-dash.c | grep "static" | grep "\-1" | wc

    132     660    4872

 

grep "{&hf" packet-dash.c | wc

    142     142    3228

 

Looks like these are your culprits:

hf_description

hf_episode_title

hf_episode_title_len

hf_has_media

hf_is_free_of_ca

hf_is_ippv

hf_is_oppv

hf_is_sub

hf_name

hf_name_len

 

 

- Chris

 

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Rach, Darshan
Sent: Friday, January 08, 2010 7:43 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Dissector bug

 

I am still unable to solve this issue.

I get the error immediately after executing this piece of code:

 

reserved = ((tvb_get_guint8(tvb, packet_field_offset) & 0xc0) >> 6);

proto_tree_add_uint(oqtp_tree, hf_reserved, tvb, packet_field_offset, 1, reserved);

 

Line 1490 in the attached packet dissector code file.

 

Your inputs would help me a lot J

 

+Darshan

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jan Gerbecks
Sent: Friday, January 08, 2010 4:31 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Dissector bug

 

Hi,

 

that usually means you forget to either: 

initialize a variable 

or didn't add it to the hf[] or ett[] array.

 

Take a closer look there,

Jan

 

On 08.01.2010, at 07:09, Rach, Darshan wrote:

 

Hi,

 

I am getting the following error:

[Dissector bug, protocol DASH: proto.c:2457: failed assertion "(guint)hfindex < gpa_hfinfo.len"]

 

My code looks like this:

 

static gint hf_epg_info_bits_len = -1;

 

{&hf_epg_info_bits_len,

{"EPG Info Bits Length","oqtp.epg_info_bits_len",FT_UINT8, BASE_DEC,NULL, 0x0,

"EPG Info Bits Length", HFILL}},

 

epg_info_bits_len = ((tvb_get_guint8(next_tvb, packet_field_offset)) & 0xf);

proto_tree_add_uint(sub_tree, hf_epg_info_bits_len, next_tvb, packet_field_offset, 1, epg_info_bits_len);

packet_field_offset += 1;

 

Kindly help.

 

+Darshan

 

---

This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@xxxxxxx and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes.
To protect the environment please do not print this e-mail unless necessary.

An NDS Group Limited company. www.nds.com
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

 

 

---

This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@xxxxxxx and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes.
To protect the environment please do not print this e-mail unless necessary.

An NDS Group Limited company. www.nds.com

CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and 
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.