Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 29427: /trunk/ /trunk/epan/dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 25 Sep 2009 14:30:19 -0700

On Aug 14, 2009, at 11:38 PM, krj@xxxxxxxxxxxxx wrote:


http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29427

User: krj
Date: 2009/08/14 11:38 PM

Log:
This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation:
1) The tvb + name (aka. data_source) is only used when the protocol tree is visible
Nope. It's also used, for example, by "tshark -x", even if "-V" isn't specified. There may be other places where it's used as well.
I've checked in a change to remove the test for a non-null, visible protocol tree. If this optimization is to be done, we need a better way of determining whether the data sources will be used.