Wireshark · Wireshark-dev: Re: [Wireshark-dev] New packet list - small fixes

["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
Checked in, together with some changes towards only storing the actually
used columns. I haven't figured out where packet_list_get_value():s column
value comes from yet. 

I get the same crash :-(
Regards
Anders 

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Jakub Zawadzki
Skickat: den 11 juli 2009 23:56
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: [Wireshark-dev] New packet list - small fixes

Hi,

This patch fix off-by-one error in packet_list_init()
and makes new_packet_list_append() to use stack for row_data_t.

Btw. There's new issue, when I load some capture into wireshark, and don't
click any packet. I got SIGSEGV on closing capture (^W) on quiting (^Q)

(gdb) bt
#0  0x000000000044ea8f in set_menus_for_selected_packet (cf=0x79e3e0) at
menus.c:2639
#1  0x000000000044a15b in main_cf_callback (event=<value optimized out>,
data=0x79e3e0, user_data=<value optimized out>) at main.c:1277
#2  0x0000000000435145 in cf_callback_invoke (event=0, data=0x79e3e0) at
file.c:146
#3  0x0000000000438c7e in cf_close (cf=0x79e3e0) at file.c:385
[cut]

2639        set_menu_sensitivity(packet_list_menu_factory, "/SCTP",
2640                             cf->current_frame != NULL ?
(cf->edt->pi.ipproto == IP_PROTO_SCTP) : FALSE);

cf->current_frame $1 = (frame_data *) 0x16bcae0,
but       cf->edt $2 = (epan_dissect_t *) 0x0