Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 29005: /trunk/epan/dissectors/ /trun
On Wed, Jul 08, 2009 at 02:46:35PM +0200, Joerg Mayer wrote:
> On Wed, Jul 08, 2009 at 12:28:57AM +0000, gerald@xxxxxxxxxxxxx wrote:
> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29005
> >
> > User: gerald
> > Date: 2009/07/07 05:28 PM
> >
> > Log:
> > Fix several dissector assertions.
> >
> > Directory: /trunk/epan/dissectors/
> > Changes Path Action
> > +25 -20 packet-glbp.c Modified
>
> The idea of doing that lastoffset = offset ... stuff was, that I am reverse
> engineering the protocol and I wanted to be able to safely resume dissection
> if one element was not of the format that I expected it to have, e.g. have
> some trailing information. Was there a specific reason to remove that
> behaviour?
Hmm, I guess it probably got just lost in the other changes. I'll add the
missing 3 lines back once I've checked against my testfiles.
Thanks for the much more elegant solution than the dissector_assert!
ciao
Joerg
--
Joerg Mayer <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
