Wireshark · Wireshark-dev: Re: [Wireshark-dev] New experimental feature: GTK2 based packet list(svn rev 28892)

["Anders Broman" <anders.broman@xxxxxxxxxxxx>]

Hi Steve,
Great job! Looks quite good I think. 
I played with it a bit and loading large files is quite slow but
removing the resorting for every row speeds it up to be 
faster than the original code I think. A 61Mb trace New packet list with
patch ~11s, old WS (SVN Rev 27374) ~16s
Memmory usage is much higher though 183 744Kb vs 252 388K. Should some
columns be stored as numbers instead of strings?
Regards
Anders

Index: packet_list_store.c
===================================================================
--- packet_list_store.c (revision 28916)
+++ packet_list_store.c (working copy)
@@ -516,7 +516,7 @@

        gtk_tree_path_free(path);

-       packet_list_resort(packet_list);
+       //packet_list_resort(packet_list);
 }

 static gboolean



-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Stephen Fisher
Sent: den 30 juni 2009 20:12
To: wireshark-dev@xxxxxxxxxxxxx
Subject: [Wireshark-dev] New experimental feature: GTK2 based packet
list(svn rev 28892)

I have commited, as svn revision 28892, an experimental new packet list
using a GTK2 tree view instead of the GTK1 based CList.  I discussed
this with a few of the core team members and others at Sharkfest09.  To
use it, define NEW_PACKET_LIST when compiling all of the files.  I've
gone crazy with #ifdef/#ifndef blocks in many filess so far, but these
can come out as the new packet list implements more of the standard
features.

To try it out with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run the configure script and then make.  I'm
not sure off the top of my head how to do this on Windows, but it should
work there too.

Feel free to ask me questions about how it is implemented so far and to
contribute to it :)

Note: The sorting by clicking on column titles is currently only
alphabetical using strcmp().


Steve

________________________________________________________________________
___
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe