Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3138] New: Buildbot crash output: fuzz
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Fri, 19 Dec 2008 00:06:18 +0100
Hi,
... and if indeed it needs to be removed the documentation (README.developer) must be adapted as well on this API change. 

Thanx,
Jaap

Guy Harris wrote:

On Dec 18, 2008, at 1:03 PM, Martin Mathieson wrote:
Sorry about that, I didn't grep to see if it was being called. Because it compiled OK I wrongly assumed it wasn't.
BTW, as it's an add_bytes routine, presumably it should take a const guint8 * pointing to the sequence of bytes to be added, the way proto_tree_add_bytes() and proto_tree_add_bytes_format_value() do. Why was the start_ptr argument removed?