Wireshark · Wireshark-dev: Re: [Wireshark-dev] stdio.h/stdlib.h includes apparently not req'd in epan/dissector source files ..

[Michael Tüxen <Michael.Tuexen@xxxxxxxxxxxxxxxxx>]

On Oct 17, 2008, at 2:12 PM, Jaap Keuter wrote:

> Hi,
>
> When what happens? Probably the buildbots are going to be oke, but  
> is that
> enough. Is that equal to.
I'm even not sure if we want to support
"every single current and historical system variant"
since we decided not to support glib 1.2 anymore...

But I think people will use the anonymous svn to get the
most recent source code. If some of them will complain,
we know which systems are affected. So committing it to
the svn tests much more than just the build bots.

I also agree, one could test it on a couple of dissectors
to minimize the work of undoing the changes in case of
that it is needed.

Best regards
Michael
> I guess not. So I think we have to look harder before we start.
>
> Thanx,
> Jaap
>
> Anders Broman wrote:
> > Hi,
> > Why not check in a subset of the changes and see what happens, if
> > there's a problem we can easily roll back.
> > Regards
> > Anders
> >
> > -----Original Message-----
> > From: wireshark-dev-bounces@xxxxxxxxxxxxx
> > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jaap Keuter
> > Sent: den 17 oktober 2008 07:33
> > To: Developer support list for Wireshark
> > Subject: Re: [Wireshark-dev] stdio.h/stdlib.h includes apparently not
> > req'd in epan/dissector source files ....
> >
> > Bill Meier wrote:
> > > Just for the record: My original reply to John follows (which I
> > > mistakenly sent only to John).
> > >
> > >
> > > John Sullivan wrote:
> > > > Random *local* include files I would whole heartedly agree, but not
> >
> > > > system ones unless you have tested on every single current and  >
> > > historical system variant.
> > >
> > >
> > > Certainly a valid point.....
> > >
> > > I'll hold off for now.
> > >
> > > Interestingly enough, I do note that just about half of the
> > > epan/dissector .c source files do not include stdio.h (and more than
> > > half do not include stdlib.h) and I've not heard of any issues with
> > > NULL & etc (although I don't know if anyone has built Wireshark with
> > GCC 4.3).
> > > Bill
> > Hi,
> >
> > From About Wireshark: "Built using gcc 4.3.1.", as every Debian/ 
> > Testing
> > installation has. So that shouldn't be a problem. Maybe it's 4.3.0
> > specific.
> >
> > Thanx,
> > Jaap
>
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> https://wireshark.org/mailman/listinfo/wireshark-dev