Wireshark-dev: Re: [Wireshark-dev] new plugin for ismacryp 1.1 protocol ready for contribution
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Thu, 2 Oct 2008 09:22:31 -0600
On Thu, Oct 02, 2008 at 05:08:59PM +0200, david.castleford@xxxxxxxxxxxxxxxxxx wrote:

> I've followed existing examples / dissectors but would appreciate help 
> from anyone who is willing to check for code quality etc.

Please open a bug at https://bugs.wireshark.org/, mark it as an 
enhancement and attach your patch to it.  You can create a patch using 
the svn client.

> Perhaps it doesn't compile on other platforms, I don't know.

It most likely will.  If accepted and added to Wireshark, it will 
automatically be built on buildbots running Windows XP, Linux, OS X and 
Solaris to ensure it compiles :).

> I'm not quite sure how to include it directly as a build-in dissector, 
> presumably the .c and .h files go directly in \epan\dissectors?

Yes.  Hopefully as just one .c and .h.  Just add it to 
epan\dissectors\Makefile.common (it's in alphabetical order) under 
DISSECTOR_SRC =


Steve