Wireshark-dev: [Wireshark-dev] Question about missing break; in packet-ncp22222.inc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Pavol Rusnak <prusnak@xxxxxxx>
Date: Fri, 05 Sep 2008 15:02:00 +0200
Hi all!
I was going through the ncp dissector code and found this (whitespace does not match): 

8541      pvalues[2].vflags = request_value->req_nds_flags;
8542      pvalues[2].nds_version = request_value->nds_version;
8543      pvalues[2].pflags = request_value->req_nds_prot_flags;
8544  case 0x04:
8545     pvalues[0].vvalue = tvb_get_guint8(tvb, nds_offset);
8546     if (pvalues[0].vvalue == 0)
I'd like to ask whether is the missing "break;" intentional or is this a bug. Thanks! 

--
Best Regards / S pozdravom,

Pavol RUSNAK                                       SUSE LINUX, s.r.o
Package Maintainer                                Lihovarska 1060/12
PGP 0xA6917144                                     19000 Praha 9, CR
prusnak[at]suse.cz                                http://www.suse.cz