Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 25579: /trunk/ /trunk/epan/: Makefil
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Tue, 24 Jun 2008 15:45:39 -0400



Jeff Morriss wrote:



Joerg Mayer wrote:

On Tue, Jun 24, 2008 at 05:57:45PM +0000, morriss@xxxxxxxxxxxxx wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=25579

User: morriss
Date: 2008/06/24 10:57 AM

Log:
Fix *NIX builds where we need our own inet_pton.c or inet_ntop.c . This should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2607 

Directory: /trunk/epan/
  Changes    Path           Action
  +10 -2     Makefile.am    Modified

Directory: /trunk/
  Changes    Path           Action
  +18 -0     Makefile.am    Modified
What's the idea of including these files into the unix builds? Just to make 
the build work? Also, will this solution work with out of tree builds?
To get the build to work if the system we're on has a broken inet_pton() or inet_ntop()--see the bug and the recent discussion of the same on the -users list. 

I *think* it will work with out-of-tree builds but I didn't test it.
Oops, no, you're right, the out-of-tree builds won't work. I was trying to fix it one way (where I thought out-of-tree builds would work) but then had to change but forgot to think of out-of-tree builds again. I'll check in a fix shortly.