Wireshark-dev: Re: [Wireshark-dev] Return -1 from a heuristic dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Martin Mathieson" <martin.r.mathieson@xxxxxxxxxxxxxx>
Date: Wed, 11 Jun 2008 15:22:43 +0100


On Wed, Jun 11, 2008 at 3:04 PM, Stig Bjørlykke <stig@xxxxxxxxxxxxx> wrote:
Hi all.

The ms-mms dissector is returning -1 in some cases where it seems to
want more data.

The attached capture has no ms-mms data, and end up with a UDP packet
not showing any Data.

Shouldn't the ms-mms dissector return 0 or something?

Section 2.7.2 of README.developer suggests that it should return 0, since that's how many bytes it has dissected.

It also shouldn't be setting desegment_len to 1.  It should either set it to DESEGMENT_ONE_MORE_SEGMENT, or (better, where known) the actual number of bytes its waiting for.
 


--
Stig Bjørlykke

_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
https://wireshark.org/mailman/listinfo/wireshark-dev