Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 25224: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Mon, 5 May 2008 02:18:22 +0200
On Sun, May 04, 2008 at 10:27:05PM +0000, stig@xxxxxxxxxxxxx wrote:
> Log:
>  Added a hidden SSID (wlan_mgt.ssid) to be able to filter on the ssid.

Why do you make this a hidden item? I'm not a big fan of hidden items as
it makes it almost impossible for the "uninitiated" to know about them.

 Ciao
      Joerg

PS: Can anyone please explain the following lines to me:

          if (tag_len < 32) {
            g_strlcpy(wlan_stats.ssid, ssid, MAX_SSID_LEN);
            wlan_stats.ssid[MAX_SSID_LEN-1] = '\0';
          }

    With MAX_SSID_LEN being defined to 32.

    - What happens if the length of the SSID equals 32? Why is
      that case ignored?
    - What happens if the SSID contains a \0 in the middle?
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.