Wireshark · Wireshark-dev: Re: [Wireshark-dev] New proto_add_bits function (Was:rev 21556:/trunk/epan//tr...)

Wireshark-dev: Re: [Wireshark-dev] New proto_add_bits function (Was:rev 21556:/trunk/epan//tr..

From: Richard van der Hoff <richardv@xxxxxxxxxxxxx>

Date: Wed, 16 Apr 2008 10:53:23 +0100

Anders Broman wrote:

Hi,
Sounds good to me,


Committed, in revision 25074.

I've been considering if we need
Different proto_tree_add_bits_ret_val()s
for 8 16 32 and 64 bits what do you think?

My main thought is that yet more proto_tree_add_* functions are likelyto be more confusing than what you gain by allowing different types ofreturn_value param. But... YMMV.


Regards

Richard

References:
- Re: [Wireshark-dev] New proto_add_bits function (Was: rev 21556:/trunk/epan//tr...)
  - From: Richard van der Hoff
- Re: [Wireshark-dev] New proto_add_bits function (Was:rev 21556:/trunk/epan//tr...)
  - From: Anders Broman

Prev by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 25062: /trunk/gtk/ /trunk/gtk/: dlg_utils.c
Next by Date: [Wireshark-dev] buildbot failure in OSX-10.4-PPC
Previous by thread: Re: [Wireshark-dev] New proto_add_bits function (Was:rev 21556:/trunk/epan//tr...)
Next by thread: [Wireshark-dev] New tshark stdin problems
Index(es):
- Date
- Thread