Wireshark-dev: Re: [Wireshark-dev] unnamed structs - epan/dissectors/packet-ieee802154.h
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Andrew Hood <ajhood@xxxxxxxxx>
Date: Fri, 21 Mar 2008 19:22:34 +1100
Stephen Fisher wrote:
> On Fri, Mar 21, 2008 at 03:01:47PM +1100, Andrew Hood wrote:
> 
> 
>>Is there any way to make use of unnamd steructs a compilation error?
> 
> 
> Not with gcc from what I can find so far.
> 
> 
>>+#define dst_addr16 dst_addr.dst_addr16
>>+#define dst_addr64 dst_addr.dst_addr64
>>+#define src_addr16 src_addr.src_addr16
>>+#define src_addr64 src_addr.src_addr64
> 
> 
> Can't we just change the uses of dst_addr16 and so on to 
> dst_addr.dst_addr16 and so on and avoid using #define?

I tried that the last time I reported unnamed structs. The code that
wound in SVN used #define. I guess the probable rationale is that it is
much less code to change.

-- 
There's no point in being grown up if you can't be childish sometimes.
                -- Dr. Who