Wireshark-dev: [Wireshark-dev] please fix your scripts and makefile script fragments!
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Greg A. Woods" <woods@xxxxxxxxxx>
Date: Wed, 27 Feb 2008 09:34:17 -0500
Please fix your scripts and makefile script fragments!

Note the following well known behaviour of test(1):

	09:02 [252] $ if test -n ; then echo true; else echo false; fi
	true
	09:02 [253] $ if test -n ""; then echo true; else echo false; fi
	false
	09:02 [254] $ if test -n "blah"; then echo true; else echo false; fi
	true
	09:02 [255] $ 

As a result not that patches such as the following are necessary for
_ALL_ of the plugins makefiles, at least as of 0.99.7:

--- plugins/ethercat/Makefile.am.orig	Mon Dec 17 20:14:47 2007
+++ plugins/ethercat/Makefile.am	Wed Feb 27 08:57:33 2008
@@ -81,7 +81,7 @@ LIBS =
 #
 plugin.c: $(DISSECTOR_SRC) $(top_srcdir)/tools/make-dissector-reg \
     $(top_srcdir)/tools/make-dissector-reg.py
-	@if test -n $(PYTHON); then \
+	@if test -n "$(PYTHON)"; then \
 		echo Making plugin.c with python ; \
 		$(PYTHON) $(top_srcdir)/tools/make-dissector-reg.py $(srcdir) \
 		    plugin $(DISSECTOR_SRC) ; \



-- 
						Greg A. Woods

H:+1 416 218-0098 W:+1 416 489-5852 x122 VE3TCP RoboHack <woods@xxxxxxxxxxx>
Planix, Inc. <woods@xxxxxxxxxx>       Secrets of the Weird <woods@xxxxxxxxx>

Attachment: pgpOdYPA4a1UP.pgp
Description: PGP signature