Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 22318: /trunk/epan/ /trunk/epan/diss
On 7/16/07, Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> wrote:
This looks pretty good, Luis.
I noticed some things that you may well already be aware of:
- when you find an unknown AVP, you no longer log it as an expert item
Not supposed to work, it's still to be added...
- I saw instances where the name shown in diameter.avp.code didn't
match the value field of the AVP, e.g. AVPs 17 and 18 (frame 115) in
the capture file I sent to you.
This should not happen, Good for reference.
- Some of the commands are not matching their entries from the XML
files (e.g. 275 which is in dictionary.xml)
Neither this one.
No, I Wasn't aware... But that's the rationale in the commit early
commit often, the sooner a bug is committed (preferably along with
some other code :-) the shorter it takes for it to get noticed the
shorter it takes for it to be fixed.
But its great to be free of the XML library and to have proper
filtering by value!
Thanks,
Martin
On 7/16/07, lego@xxxxxxxxxxxxx <lego@xxxxxxxxxxxxx> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22318
>
> User: lego
> Date: 2007/07/16 05:42 AM
>
> Log:
> Rewrite of the diameter dissector to use the dictionary for creating hfids,
> drop libxml dependency.
>
> The work is still incomplete (anything but strings and numbers appears as
> bytes) but I want others to start testing it.
>
> TODO:
> builders and decoders for:
> - (ntp) timestamps
> - addresses
> - diameteruris
> - diameteridentities
> - ipfilterrules
> - qosfilterrules
> - mipregistrationrequests
>
> Directory: /trunk/epan/dissectors/
> Changes Path Action
> +659 -2211 packet-diameter.c Modified
>
> Directory: /trunk/epan/
> Changes Path Action
> +81 -0 diam_dict.h Added
> +759 -0 diam_dict.l Added
>
> _______________________________________________
> Wireshark-commits mailing list
> Wireshark-commits@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-commits
>
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
