Wireshark-dev: Re: [Wireshark-dev] [PATCH] Fix State management of MySQL dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jess Balint <jbalint@xxxxxxxxx>
Date: Mon, 25 Jun 2007 20:18:33 -0500
On Mon, Jun 25, 2007 at 05:59:34PM -0700, Stephen Fisher wrote:
> 
> Thanks for your follow-up; sometimes patches slip through the cracks.  
> My only question is what exactly is the problem that this patch solves?  
> Forgive me as I am not very familiar with the MySQL dissector or 
> protocol.

Hi Stephen - The problem with the MySQL dissector is that it tracks
state in a static variable. This is manifested in the GUI when clicking
on packets out of order. The starting state for parsing the packet can
be wrong causing it to just show "unknown, etc". This patch adds a
state-tracking array (1 byte per packet) so that when packets are
displayed out of order the correct starting state to parse the packet
is known.

Jess