Wireshark-dev: Re: [Wireshark-dev] [PATCH] Fix compilation failures on x86_64-unknown-linux-gnu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Thu, 31 May 2007 12:50:53 -0700
On Wed, May 30, 2007 at 10:18:08AM +0800, Jeff Morriss wrote:

> Possibly stupid question (and a bit too late since you already did the 
> above but it might be worth it for the simplification for future 
> coders): do we still need GTK1.2 on Windows?  I (and some others) 
> still need it on Unix (because of the massive list of dependencies for 
> GTK2 or just plain old systems) but does anybody actually use the 
> GTK1.2 Windows version?

I can think of two reasons to keep it in the Windows build.  Recently, 
GTK2 introduced a bug where Wireshark no longer displays properly in 
256-color mode on Windows (often seen through terminal services sessions) 
and someone said that the GTK1 version can be installed as a workaround 
to this problem (we have a bug open with the GTK folks on this).  Also, 
having the Windows build bot compile the GTK1 and GTK2 versions is 
helpful to spot breakage in the GTK1 build for when we accidentally use a 
function that is GTK2 only (this happened to me just a couple of days 
ago).  Other than those reasons, I see no reason to keep it around in 
the Windows build.


Steve