Wireshark-dev: Re: [Wireshark-dev] [PATCH] RTP/RTCP SSRC values in Hex
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Thu, 31 May 2007 11:41:39 -0700
I've committed your changes as SVN revision 22017.  Thanks!

On Thu, May 31, 2007 at 10:52:44AM +0200, Lars Ruoff wrote:
> 
> Hi Stephen,
> yes it should be changed to BASE_HEX_DEC.
> And yes, the patch is not to latest SVN but to SVN-21602 (this *was* the latest when i first submitted the patch :-) ).
> And yes, is see in the files, that --- is my modified version, while +++ is the base i diffed against.
> Sorry if i got something mixed up there. I don't use unix diff regularly.
> Thanks for your effort,
> Lars
> 
> 
> Stephen Fisher wrote:
> > On Mon, May 28, 2007 at 01:43:40PM +0200, Lars Ruoff wrote:
> > 
> >> Another try...
> > 
> > Sorry for the delay.
> > 
> >>>>> Lars Ruoff wrote:
> >>>>>> Hi,
> >>>>>> find attached several trivial diffs for viewing RTP SSRC values in 
> >>>>>> Hex rather than Dec at various places in the UI.
> >>>>>> Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding 
> >>>>>> RTP and RTCP dissector header fields.
> > 
> > The patches aren't applying to my source tree.  You said that you're 
> > changing from BASE_DEC to BASE_HEX_DEC, but in the patches it says:
> > 
> > -                               BASE_HEX_DEC,
> > +                               BASE_DEC,
> > 
> > .. as if you're doing the opposite.  It is currently a BASE_DEC and you 
> > want to change it to BASE_HEX_DEC, right?  Even when I try to do a 
> > reversed patch apply (patch -R) it fails.  That could be just because 
> > the lines are off if your patches aren't to the latest SVN.  I just 
> > wanted to confirm before I try to apply the changes by hand.
> > 
> > 
> > Steve
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev