Wireshark-dev: Re: [Wireshark-dev] [PATCH] Firebird/Interbase dissector, request for comments
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Sat, 19 May 2007 09:30:14 +0200
On Fri, May 18, 2007 at 06:50:10PM +0200, M?she Van der Sterre wrote:
> Here is a new patch.
> If someone has anything to comment on it, please do so.

It looks good but for one major and one minor thing:

Major:
+#define HANDLE_FUNC_TYPE       int
+#define HANDLE_FUNC_PARAMS     tvbuff_t *tvb, packet_info *pinfo, proto_tree
+*tree
+#define HANDLE_FUNCTION(name)  HANDLE_FUNC_TYPE name ( HANDLE_FUNC_PARAMS )

has to go. It makes reading the code harder for no real gain.

Minor:
You are not providing any preferences settings. In case you don't intend
to do so in the future, there is no need to include prefs.h.

 ciao
     Joerg