Wireshark-dev: Re: [Wireshark-dev] Patch to AMQP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>
Date: Tue, 27 Mar 2007 22:10:28 +0000
Why do you change all function argumentns to use _U_ ?

_U_ is only used to mark a parameter as unused so that the compiler
will not emit any warnings "parameter foo is never used".

You only set this _U_ for arguments that are indeed never used inside
the function to suppress these kinds of compiler warnings.


Can you resubmit the patch after removing and reviewing these _U_ changes?


On 3/27/07, Martin Sustrik <sustrik@xxxxxxxxxx> wrote:

Hi Ronnie,

here's a patch to AMQP dissector. The only change is that when there are
seceral AMQP frames in single TCP packet, all of them are referred in
the info column.

Can you check it in?

Thanks.
Martin