Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21130: /trunk/epan/dfilter/ /trunk/epan/dfilter/: Makefi

[Stephen Fisher <stephentfisher@xxxxxxxxx>]

grammar.c: In function `DfilterTokenName':
grammar.c:351: warning: comparison between signed and unsigned

I manually edited it to fix the warning, but didn't see it in my commit 
so I got suspicious.  I didn't remember that grammar.c was svn:ignore 
and works with lemon.  Here's the code snippet:

/*
** This function returns the symbolic name associated with a token
** value.
*/
const char *DfilterTokenName(int tokenType){
#ifndef NDEBUG
  if( tokenType>0 && 
tokenType<(sizeof(yyTokenName)/sizeof(yyTokenName[0])) ){
    return yyTokenName[tokenType];
  }else{

If I change the argument to the function to guint, the warning goes 
away.  I haven't looked closely enough to see if it is in other lemon 
generated parsers yet.  Any ideas?  

On Fri, Mar 23, 2007 at 12:31:33AM +0100, Luis Ontanon wrote:

> Which warning?
> is it unique to grammar.c or it appears in other lemon generated parsers?
> 
> On 3/23/07, sfisher@xxxxxxxxxxxxx <sfisher@xxxxxxxxxxxxx> wrote:
> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21130
> >
> > User: sfisher
> > Date: 2007/03/22 11:28 PM
> >
> > Log:
> >  Remove -Werror under gcc temporarily until a warning can be fixed
> >  in grammar.c
> >
> > Directory: /trunk/epan/dfilter/
> >   Changes    Path           Action
> >   +0 -4      Makefile.am    Modified
> >
> > _______________________________________________
> > Wireshark-commits mailing list
> > Wireshark-commits@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-commits
> >
> 
> 
> -- 
> This information is top security. When you have read it, destroy yourself.
> -- Marshall McLuhan
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev