Wireshark-dev: [Wireshark-dev] [PATCH] Fix bugs in IuUP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Kriang Lerdsuwanakij <lerdsuwa@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 31 Jan 2007 21:20:25 +0700
Hello

While I reading source code of IuUP dissector, I notice some
obvious bugs inside the code. One is a missing assignment
that causes the following "if (iuup_circuit)" block to never execute.
Another is wrong field names.

Althoug both won't show up in final result (for the first bug, the call to
g_hash_table_insert several lines later will do the right thing anyway;
for the second bug, there is no services utilizing more than 3 subflows),
I think it is better to have them fixed. Patch is in the attachment.

Best regards

Kriang Lerdsuwanakij

Attachment: patch-iuup.gz
Description: GNU Zip compressed data