Thanks for comments.
Of course, I removed the message to stop coming out after I realized
that it is coming before preferences.
Creating file in my system does not address this problem for others.
Elegant solution would be perhaps to postpone reading the directory until
it is really needed.
Alternatively, put the error message to tree output of relevant packets.
This way the user would realize very fast why his packets are not
decoded, while others do not see irrelevant warning.
I am still wondering whether radius is the only dissector that uses
external file. If not, how do the others handle this kind of issue?
I also failed to understand why tshark does not give this warning message.
Regards
Andrej
On Sat, 27.Jan.07 01:55:35 +0100, Luis Ontanon wrote:
> The radius dictionary gets loaded way before preferences are
> evaluated. Giving no warning and then having the packets undecoded
> isn't elegant.
>
> Your patch suppresses the error altoghether which is not a nice solution.
>
>
> What you can do is just add a dummy radius dir and a dummy dictionary:
>
> $ cd $WIRESHARK_DATA
> $ mkdir radius
> $ touch radius/dictionary
>
> 3 commands and the Warning is gone.
>
>
> On 1/27/07, Andrej Mikus <wireshark-dev@xxxxxxxx> wrote:
> > Team,
> >
> > I notice that wireshark emits unconditionally warning mentioning that it
> > Could not find the radius directory.
> >
> > I do not think that radius dictionary is needed for operation in all
> > environments, is is possible to move this output to some kind of
> > diagnostics mode?
> >
> > Based on my search, it appears there for some time:
> > http://www.wireshark.org/lists/wireshark-bugs/200610/msg00501.html
> >
> > I applied following patch:
> >
> > Index: epan/dissectors/packet-radius.c
> > ===================================================================
> > --- epan/dissectors/packet-radius.c (revision 20564)
> > +++ epan/dissectors/packet-radius.c (working copy)
> > @@ -1469,7 +1469,6 @@
> > dict = radius_load_dictionary(dir,"dictionary",&dict_err_str);
> > } else {
> > dict = NULL;
> > - dict_err_str = g_strdup("Could not find the radius directory");
> > }
> >
> > g_free(dir);
> >
> >
> > Thanks
> > Andrej
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> >
>
>
> --
> This information is top security. When you have read it, destroy yourself.
> -- Marshall McLuhan
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
