Wireshark-dev: Re: [Wireshark-dev] Problems encountered on Windows building from a "source tarb
Guy Harris wrote:
> Gerald Combs wrote:
>
>> I'm in the process of moving the contents of airpdcap to epan/crypt.
>> Once that's done I'll add it to the distribution.
>
> Some warnings from my build on OS X 10.4:
> airpdcap.c:1045: warning: comparison of unsigned expression < 0 is
> always false
Fixed.
> In file included from airpdcap_wep.c:5:
> airpdcap_int.h:62: warning: malformed '#pragma pack' - ignored
> airpdcap_int.h:109: warning: malformed '#pragma pack' - ignored
>
> Do those structures need "#pragma pack"? If so, could the code be
> changed not to require that? Not all C compilers support "#pragma
> pack", as far as I know, and even those that do apparently don't support
> it in the same way, for example:
I doesn't look like it's required, as per your later messages. I've
surrounded the "#pragma pack" sections with "#ifdef"s for the time being.
> 1) Should all the crypt-XXX.[ch] files in the epan directory be moved
> to the epan/crypt directory?
Yes.
> 2) Can any code be shared between epan/crypt-md5.[ch] and
> epan/crypt/airpdcap_md5.[ch]?
It doesn't look like airpdcap_md5.[ch] is being used right now; I'll
look into removing it.
