Wireshark · Wireshark-dev: [Wireshark-dev] [patch] Small change to show SSL session ID's

[Sake Blok <sake@xxxxxxxxxx>]

Hi,

The attached patch changes the way the ssl-session-id is displayed.
Currently it is not shown, only the length is shown like this:

   Session ID Length: 32
   Session ID (32 bytes)

To me, it is not useful to repeat the length and omit the ID itself.
With this patch the ssl-session-id is shown like this:

   Session ID Length: 32
   Session ID: A4B2FB0EE6D8F58DEFF68E38B1E5B4C25F1869D4BC86A96E...

Please consider this patch for inclussion :)

Cheers,


Sake

Index: epan/dissectors/packet-ssl.c
===================================================================
--- epan/dissectors/packet-ssl.c        (revision 20208)
+++ epan/dissectors/packet-ssl.c        (working copy)
@@ -1589,12 +1589,9 @@
         if (session_id_length > 0)
         {
             tvb_ensure_bytes_exist(tvb, offset, session_id_length);
-            proto_tree_add_bytes_format(tree, hf_ssl_handshake_session_id,
+            proto_tree_add_bytes(tree, hf_ssl_handshake_session_id,
                                          tvb, offset, session_id_length,
-                                         tvb_get_ptr(tvb, offset, session_id_length),
-                                         "Session ID (%u byte%s)",
-                                         session_id_length,
-                                         plurality(session_id_length, "", "s"));
+                                         tvb_get_ptr(tvb, offset, session_id_length));
             offset += session_id_length;
         }