Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 20115: /trunk/test/ /trunk/test/: co
gerald@xxxxxxxxxxxxx wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20115
User: gerald
Date: 2006/12/11 06:24 PM
Log:
The capture test suite currently fails on quiet networks. Try to fix
this by generating some ICMP packets before each test. Add an "icmp"
capture filter to each test to better control the test conditions.
Fixup whitespace.
Sounds like a good approach.
The icmp packet filter might not be needed, as we only need at least a
little bit of traffic in a reasonable amount of time - the traffic
captured simply doesn't matter - and doesn't require to be icmp traffic
therefore.
I don't know if the current solution will work on cygwin (the test
platform I use) ... no time to test it myself :-(
When I remember correct, the stdout test is failing on my machine too -
the test implementation itself is ok. Some one (myself?) changed WS or
dumpcap in a way that this test fails since I've written this test.
Either someone finds the time to fix it (I currently won't have in the
next weeks) or we could disable this test for now so the buildbot get's
at least green now (and we can easily recognize if another test gets
red) ...
Regards, ULFL
