Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 20049: /trunk/ /trunk/epan/dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Thu, 7 Dec 2006 12:12:00 +0100
Gerald,

On Wed, Dec 06, 2006 at 02:53:31PM -0800, Gerald Combs wrote:
> The WPA code (specifically the modules in the airpdcap directory) is
> Windows-specific because we might use same code base for WPA decryption
> in Wireshark and in the Airpcap driver.  We're working on
> de-Windows-izing the code, which should be done in the next few days.
> At that point we can remove the HAVE_AIRPDCAP define.

:-)

> BTW, we now have encryption code in airpdcap/* and epan/crypt-*.[ch].
> (including duplicate MD5 implementations).  Should this all be moved to
> a common directory, e.g. epan/crypt/?

Yes, I think that would be the proper place.

> As far as the Airpcap code being Windows-specific: we've tried to
> generalize it so that it can be adapted to other platforms.  There's no
> reason the code that calls airpcap_if_set_device_channel() under Windows
> can't (and shouldn't) use the SIOCSIWFREQ ioctl under Linux.

The long term best place would be an integration of the capture part of
airpcap into libpcap, but until such a time adding support for other
OSses into airpcap would be nice too.

Btw, the files in airpcap (except the Makefile) lack copyright headers
and license information headers.

 Ciao
      Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.