Stephen Fisher wrote:
I am looking at bug #948, "Apply capture preferences not applying."
The problem reported is that if you update a preference such as "Update
list of packets in real time" and hit apply/OK then go to the capture
options screen, the change is not reflected there. Glancing at the
code, it looks like these preferences are only synchronized in main()
when the program starts up - for example: capture_opts->promisc_mode =
prefs->capture_prom_mode;
Does anyone see any reason why updates to the capture options in the
preferences should not also update the capture options without having to
restart the program? I don't think it should work the other way around
though - the capture options screen feels more like per capture options
to me.
As you (and the bug report) have mentioned, changes in the Preferences
should affect the settings in capture_opts - the current behaviour is
just a bug.
Changes in capture_opts e.g. in the "Capture Options" dialog - shouldn't
change the Preferences settings (it would be odd if it would work that way).
A slightly different question remains:
Do we need these capture related Preference settings anymore as we have
the recent file now?
At the time these settings were introduced, the recent file just wasn't
existing.
A more "natural" approach to my eyes would be to save the interface
settings (and alike) in the recent file ...
Unfortunately, this leaves the questions open how tshark should be
working as it's only working with the settings in the Preferences file :-(
So just feel free to fix it - the question I've raised is a slightly
different one ...
Regards, ULFL
