Wireshark-dev: Re: [Wireshark-dev] Use of gcrypt and gnutls in version_info.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 7 Nov 2006 09:43:47 +0100
On Mon, Nov 06, 2006 at 09:20:22PM -0600, Albert Chin wrote:
> version_info.c has:
>   #ifdef HAVE_LIBGCRYPT
>   #include <gcrypt.h>
>   #endif /* HAVE_LIBGCRYPT */
> 
>   #ifdef HAVE_LIBGNUTLS
>   #include <gnutls/gnutls.h>
>   #endif /* HAVE_LIBGNUTLS */
> 
> However, Makefile.am doesn't include the necessary CPPFLAGS/LDFLAGS to
> resolve symbols from the above. Patch attached.
...
> @@ -459,6 +460,7 @@
>  dumpcap_LDADD = \
>  	$(dumpcap_additional_libs)	\
>  	@GLIB_LIBS@			\
> +	@LIBGCRYPT_LIBS@		\
>  	@PCAP_LIBS@ @SOCKET_LIBS@ @NSL_LIBS@

Hmm, the fix is correct, but if we need to links dumpcap with gnutls
just to handle the version stuff, then something more fundamental is
broken with our version stuff. There should be a better solution to
this problem. 

Committed revision 19853.
(until a time the "proper" fix is done :)

Thanks!
    Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.