Wireshark · Wireshark-dev: Re: [Wireshark-dev] contribution: OpenChange dissector for NSPI protocol

["ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>]

i have regenerated the dissector using latest pidl and checked it in.


some comments:

1, shouldnt
#define PT_UNSPECIFIED  0x0000
#define PT_NULL         0x0001
#define PT_I2           0x0002
be an enum instead?
That would make dissection much prettier.

See some of the other idl files for examples on how to use 16 or 32 bit enums.


2, have a look at the winreg.cnf conformance file, the section about
tracking policy handles.
This feature will add an expansion to policy handles to tell the user
in which frame they were opened/created or closed/destroyed



3,  can out add a nice page to the wiki and a few example captures
containing as many as possible of the NSPI commands?




On 11/4/06, Julien Kerihuel <j.kerihuel@xxxxxxxxxxxxxx> wrote:
> The NspiGetMatches issue is fixed.
>
> No modifications have been brought to the IDL, only fixes in
> Wireshark/NDR.pm
> (branch SAMBA_4_0 Wireshark/NDR.pm) with rev 19559.
>
> Regards.
>
> On Saturday 04 November 2006 19:00, Joerg Mayer wrote:
> > On Sat, Nov 04, 2006 at 05:38:18AM +0200, Julien Kerihuel wrote:
> > > some news about the NSPI dissector improvements/bugs/fixes:
> > >
> > > The new version of the dissector will compile without any patches to
> > > apply to Wireshark/NDR.pm. Jelmer has improved the patch and pidl now
> > > support enums as return type. Regarding the nspi.cnf file, it won't be
> > > useful anymore.
> > >
> > > Regarding the dissector, I've noticed a bug in NspiGetMatches which
> isn't
> > > dumped correctly. I'm currently investigating the problem and I'll
> notify
> > > the list when a fixed version is available.
> >
> > Checked into the wireshark source (./idl/nspi/) and the main dissector
> > repo.
> >
> > Committed revision 19794.
> >
> > thanks
> >      Joerg
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
> --
> Julien Kerihuel
> j.kerihuel@xxxxxxxxxxxxxx
> OpenChange Project Manager
>
> GnuPG Key: http://jkerihuel.openchange.org/keys/kerihuel_gpg_public.asc