Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Patch] Re: capture from a fifo

[Ulf Lamping <ulf.lamping@xxxxxx>]

Richard van der Hoff wrote:
> Richard van der Hoff wrote:
> > [tshark from a fifo]
> > Ulf - I notice you made the relevant change here (r16787) - is there 
> > any reason why tshark shouldn't use capture_loop_dispatch to do its 
> > processing, rather than attempting to use cap_pipe_dispatch or 
> > pcap_dispatch directly?
>
> well, there didn't seem to be, so I've made a patch which does exactly 
> this, and which fixes the problem.
>
> I've even gone so far as to add a unit test for it :).
>
> Please could this be applied?
Hi Richard, sorry for the very late response!

Yes, there are reasons to use the same code for Wireshark and Tshark:

- having duplicated and slightly different code for the same task is a 
bad thing (unless there are *very* good reasons to do so)
- these were the first steps towards privilege seperation (which are 
mostly finished in Wireshark but needs to be finished in Tshark)

So rolling back the changes I've done is not the way we want to go.

Regards, ULFL