Wireshark-dev: Re: [Wireshark-dev] [wireshark-dev] patch for packet-ppp.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Mon, 4 Sep 2006 16:12:56 +0200 (CEST)
Hi,

Good catch, checked in.

Thanx,
Jaap

On Mon, 4 Sep 2006, Donald White wrote:

> I have found three more bugs in the dissect_pppmux() function of
> packet-ppp.c.  A patch is attached.
>
> First, the length of the header of a sub-frame may be miscalculated if
> if the PID field is not present, but was present in a previous
> sub-frame.  The calculation of the header length will use the value from
> the previous sub-frame.
>
> Second, correct the typo "ength" to "length".
>
> Third, the length of the current sub-frame was not passed as the
> reported length to a sub-dissector.  When the sub-dissector calls
> tvb_reported_length(), the function returns the length of the complete
> frame and not the length of the sub-frame to be dissected.
>
> Regards,
>
> Don
>