Wireshark-dev: Re: [Wireshark-dev] MEGACO patch is incorrect?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Mon, 19 Jun 2006 17:43:39 +0200
Checked in.
Brg
Anders

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Tarlovskij Eugene
Skickat: den 19 juni 2006 14:25
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: [Wireshark-dev] MEGACO patch is incorrect?


Recently I've posted patch for MEGACO dissector which eliminates "Invalid
offset" error in ObservedEvents descriptor. The patch simply removes equal
sign from line 2046 of packet-megaco.c.

-			if (tvb_current_offset <= tvb_previous_offset) {
+			if (tvb_current_offset < tvb_previous_offset) {


After synchronization with wireshark repository I see that the patch is
applied in the incorrect way. The source code contains "equal" sign!

            if (tvb_current_offset = tvb_previous_offset) {

So, recent repository version still incorrect, and even more incorrect than
previous. 

I send you another patch to fix this issue.

Best,
Eugene Tarlovskij