Wireshark-commits: [Wireshark-commits] master f91e653: lldp: show the Protocol Identity as bytes, n
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Aug 2020 05:56:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f91e6535c2aa17466a06bcaf62f4019df5b2ee68
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f91e653 by Guy Harris (gharris@xxxxxxxxx):

    lldp: show the Protocol Identity as bytes, not a text string.
    
    Section D.2.4.3 "protocol identity" of IEEE 802.1Q-2018 says:
    
        The protocol identity field shall contain the first n octets of the
        protocol after the layer 2 addresses (i.e., for example, starting
        with the EtherType field) that the sender would like to advertise.
    
    Show it as FT_BYTES, not FT_STRINGZ.
    
    Add a comment explaining that, and expand a comment to indicate what
    specifications there are for LLDP and some Organizationally Specific
    TLVs.
    
    Change-Id: I8c41026379731d1c05134d6e7ad563227f9fbfde
    Reviewed-on: https://code.wireshark.org/review/38229
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  82a4968   plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()
     add  f91e653   lldp: show the Protocol Identity as bytes, not a text string.


Summary of changes:
 epan/dissectors/packet-lldp.c | 34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)