Wireshark-commits: [Wireshark-commits] master e7116cc: packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Aug 2020 05:11:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7116cca75937d96d5795340388a519ee8e6f882
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e7116cc by Harald Welte (laforge@xxxxxxxxxxx):

    packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected
    
    3GPP TS 48.016 specifies GPRS-NS over Frame Reley. In Section
    6.1.1 it explicitly states that ITU-T Q.933 Annex A for FR PVC
    must be supported.  In real-world Gb-over-FR protocol traces I also
    see related LMI messages on DLCI=0.
    
    Hence, let's not dispatch DLCI=0 messages to the GPRS-NS dissector,
    where they are all detected wrongly.  Only non-zero DLCI are NS-VC.
    
    Change-Id: I6ce3557cda0da31323a851008bf648047ba1f926
    Reviewed-on: https://code.wireshark.org/review/38211
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  217a929   FSSO: Fix when additionnal data is not coming from TSAgent
     add  e7116cc   packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected


Summary of changes:
 epan/dissectors/packet-fr.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)