Wireshark-commits: [Wireshark-commits] master-3.2 f404b09: PROFINET: DHCP suboption undefined bytes
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Aug 2020 13:28:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f404b094375343f0fab145df23663998bf4fc698
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

f404b09 by Basak Kalfa (basakkalfa@xxxxxxxxx):

    PROFINET: DHCP suboption undefined bytes
    
    There are undefined bytes which must be included in DHCP
    suboption block according to DCP Block Length. In other
    words, there are still bytes after dissection of defined
    parameters finish but DCP block length does not finish.
    In order to solve the problem, these bytes are included in
    DHCP suboption block and marked Undefined. The byte number
    can be 1, so bytes word in pn_user_data is changed to byte.
    
    Change-Id: I2be23b41a9827f9c2159b97a05658ddf557865cf
    Reviewed-on: https://code.wireshark.org/review/38203
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    (cherry picked from commit 4e595577f3dc2cd673ae6a06cec6ecc086ba8975)
    Reviewed-on: https://code.wireshark.org/review/38205
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a2606dc   TDS: Fix If COLMETADATA is present, all row data display is unusable.
     add  f404b09   PROFINET: DHCP suboption undefined bytes


Summary of changes:
 plugins/epan/profinet/packet-pn-dcp.c | 7 +++++++
 plugins/epan/profinet/packet-pn.c     | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)