Wireshark-commits: [Wireshark-commits] master-3.2 8b869ac: C12.22: Fix Calling-authentication-value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Aug 2020 11:08:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b869ac40aa8df5f424e065dcaf572fecd060661
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

8b869ac by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    C12.22: Fix Calling-authentication-value-c1221 CHOICE
    
    This ASN.1 CHOICE has three items with the same tag. Without access
    to the spec, assuming these are sequentially numbered change the tags
    on the subsequent elements.
    This is detected by conflict check.
    
    Change-Id: I0d7e6ace53426ba2661b133f7e825c1a305338ef
    Reviewed-on: https://code.wireshark.org/review/37697
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Ed Beroset <beroset@xxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 7db43f0b8900af8db821d78c6d3c93fd144edb56)
    Reviewed-on: https://code.wireshark.org/review/38189
    

Actions performed:

    from  464ac0a   E212: Update MCC / MNC code interpretations
     add  8b869ac   C12.22: Fix Calling-authentication-value-c1221 CHOICE


Summary of changes:
 epan/dissectors/asn1/c1222/c1222.asn | 16 ++++++++--------
 epan/dissectors/packet-c1222.c       |  8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)