Wireshark · Wireshark-commits: [Wireshark-commits] master 3b67c5b: TFS: Add some commonly-defined string pairs to tfs.c

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b67c5b3084cd74986115e06eab954b4f8332a3f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3b67c5b by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    TFS: Add some commonly-defined string pairs to tfs.c
    
    'check_tfs.py --common'    can look for tfs values that appear multiple times.
    Current output prior to these dssector changes was:
    
    ('No Extension', 'Extension') appears 3 times in:  ['epan/dissectors/packet-bssap.c', 'epan/dissectors/packet-camel.c', 'epan/dissectors/packet-gsm_map.c']
    ('Optimised for signalling traffic', 'Not optimised for signalling traffic') appears 3 times in:  ['epan/dissectors/packet-gsm_a_gm.c', 'epan/dissectors/packet-gsm_map.c', 'epan/dissectors/packet-gtp.c']
    ('Data PDU', 'Control PDU') appears 3 times in:  ['epan/dissectors/packet-pdcp-lte.c', 'epan/dissectors/packet-pdcp-nr.c', 'epan/dissectors/packet-rlc-nr.c']
    ('Message sent to originating side', 'Message sent from originating side') appears 3 times in:  ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c']
    ('User', 'Provider') appears 3 times in:  ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c']
    
    The first and last ones were made common, the others seem a little too specialised.
    
    Checking some of the existing items in tfs.c (using QtCreator's 'Find Usages'),
    some of the common items are used a lot, but many of them are not referenced.
    
    Change-Id: Ia4006d2c4fa7cafbc3b004dc7a367a986dbeb0c4
    Reviewed-on: https://code.wireshark.org/review/38177
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e48ab21   BER: Fix order of loop tests to avoid overrunning array.
     add  3b67c5b   TFS: Add some commonly-defined string pairs to tfs.c


Summary of changes:
 debian/libwireshark0.symbols                       |  2 +
 epan/dissectors/asn1/camel/packet-camel-template.c |  6 ---
 .../asn1/gsm_map/packet-gsm_map-template.c         |  7 +---
 epan/dissectors/packet-bssap.c                     |  7 +---
 epan/dissectors/packet-camel.c                     | 20 ++++------
 epan/dissectors/packet-gsm_map.c                   | 13 +++----
 epan/dissectors/packet-q2931.c                     |  1 -
 epan/dissectors/packet-q931.c                      |  1 -
 epan/dissectors/packet-q933.c                      |  1 -
 epan/tfs.c                                         |  2 +
 epan/tfs.h                                         |  2 +
 tools/check_tfs.py                                 | 43 +++++++++++++++++++---
 12 files changed, 58 insertions(+), 47 deletions(-)