Wireshark-commits: [Wireshark-commits] master 395ac51: Fix some cases where item mask was wider tha
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2020 16:24:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=395ac51703b235b4344d396dd01ce8345dde294f
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

395ac51 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    Fix some cases where item mask was wider than item type.
    
    Error:  epan/dissectors/packet-docsis.c filter= docsis.ehdr.rsvd FT_UINT8 so field_width= 8 but mask is 0x3FFF which is 14 bits wide!
    Error:  epan/dissectors/packet-ixveriwave.c filter= ixveriwave.contextp.agc FT_BOOLEAN so field_width= 1 but mask is 0x0038 which is 3 bits wide!
    
    N.B. The ixveriwave field was not in use, so was deleted.
    
    Change-Id: Ife73eb9204f7339cc0fe2b4e991f0df553823ffe
    Reviewed-on: https://code.wireshark.org/review/38140
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  2d74b5c   EPL: modified timestamp format of errorcodelist
     add  395ac51   Fix some cases where item mask was wider than item type.


Summary of changes:
 epan/dissectors/packet-docsis.c     | 2 +-
 epan/dissectors/packet-ixveriwave.c | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)