Wireshark-commits: [Wireshark-commits] master dae7f76: tacacs: various fixes and cleanups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2020 01:22:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dae7f769e8b6f3afc46a28bac5ab6c3449b870e5
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

dae7f76 by Guy Harris (gharris@xxxxxxxxx):

    tacacs: various fixes and cleanups.
    
    Update URL for the TACACS+ I-D - point to the IETF site.
    
    Fix code indentation.
    
    Use proto_tree_add_item_ret_uint() to get string lengths when adding
    them to the protocol tree.
    
    Put the username and password under the top-level tree item, rather than
    at the top level themselves.
    
    The username and password are counted strings, and are not
    null-terminated; make them FT_STRING rather than FT_STRINGZ.
    
    Change-Id: Ia974937ade5908f98c0b527586e8ac15c3ffb907
    Reviewed-on: https://code.wireshark.org/review/38130
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  b1753ce   Qt: Add debugging ifdefs for the packet diagram.
     add  dae7f76   tacacs: various fixes and cleanups.


Summary of changes:
 epan/dissectors/packet-tacacs.c | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)