Wireshark · Wireshark-commits: [Wireshark-commits] master a582672: lithionics: use ws_strtou32() and ws_hexstrtou32() to convert st

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a582672d6f9bf5706849ccbb7da49f02066552af
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a582672 by Guy Harris (gharris@xxxxxxxxx):

    lithionics: use ws_strtou32() and ws_hexstrtou32() to convert strings.
    
    Those routines do more checking than strtoul(), and get passed a pointer
    to a guint32(), so you don't have to worry about 32-bit vs. 64-bit longs
    (which causes warnings on macOS builds, courtesy of Apple throwing in
    "narrowing 64-bit value to 32 bits" warnings when they introduced their
    first 64-bit machines, to help developers 64-bitifying their
    applications, causing macOS builds to fail).
    
    If the checks fail, note that in the formatted value.
    
    (XXX - assign units to the fields, so we don't have to add them in our
    formatting?)
    
    Change-Id: I35945a3f1eaedc88e5b2ebf500c06fb7cf022753
    Reviewed-on: https://code.wireshark.org/review/38119
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  2db3708   Add Lithionics battery management dissector.
     add  a582672   lithionics: use ws_strtou32() and ws_hexstrtou32() to convert strings.


Summary of changes:
 epan/dissectors/packet-lithionics.c | 67 +++++++++++++++++++++++++++----------
 1 file changed, 50 insertions(+), 17 deletions(-)