Wireshark-commits: [Wireshark-commits] master 151ee60: http3: fix build without support for AEAD ci
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2020 21:14:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=151ee605559ac0d61eb8618a75985772c57dbfa8
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

151ee60 by Guy Harris (gharris@xxxxxxxxx):

    http3: fix build without support for AEAD cipher suites.
    
    http3_is_reserved_code() is only used if HAVE_LIBGCRYPT_AEAD is defined;
    only define http3_is_reserved_code() if HAVE_LIBGCRYPT_AEAD is defind.
    
    (Then there's the issue that HAVE_LIBGCRYPT_AEAD is *NOT* defined as a
    result of CMake tests, it's defined in packet-tls-utils.c based on the
    libgcrypt version, so it's not as if it can be used outside
    packet-tls-utils.c, but that's another bug to fix.)
    
    Change-Id: Ibecdf6e12fde27d75fcd7849ca0cd62f4129f5c2
    Reviewed-on: https://code.wireshark.org/review/38114
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  c462f72   IEEE802.11: WAN Metrics Length Check Update
     add  151ee60   http3: fix build without support for AEAD cipher suites.


Summary of changes:
 epan/dissectors/packet-http3.c | 2 ++
 1 file changed, 2 insertions(+)