Wireshark-commits: [Wireshark-commits] master 9b07412: Qt: Add a packet diagram view.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2020 18:18:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b07412277b4436b30410bd07e9cb8ee0b88ddb2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9b07412 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add a packet diagram view.
    
    Add a new top-level view that shows each packet as a series of diagrams
    similar to what you'd find in a networking textook or an RFC.
    
    Add proto_item_set_bits_offset_len so that we can display some diagram
    fields correctly.
    
    Bugs / to do:
      - Make this a separate dialog instead of a main window view?
      - Handle bitfields / flags
    
    Change-Id: Iba4897a5bf1dcd73929dde6210d5483cf07f54df
    Reviewed-on: https://code.wireshark.org/review/37497
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e846d23   QUIC: fix compile  without LIBGCRYPT_AEAD
     add  9b07412   Qt: Add a packet diagram view.


Summary of changes:
 docbook/release-notes.adoc             |   1 +
 docbook/wsug_src/WSUG_chapter_use.adoc |  21 +
 epan/dissectors/packet-ip.c            |  18 +-
 epan/dissectors/packet-tcp.c           |   1 +
 epan/prefs.c                           |   1 +
 epan/prefs.h                           |   3 +-
 epan/proto.c                           |   9 +
 epan/proto.h                           |   9 +-
 test/README.test                       |   1 +
 test/baseline/dhcp-raw.ek              |   8 +-
 test/baseline/dhcp.jsonraw             |  16 +-
 ui/qt/CMakeLists.txt                   |   2 +
 ui/qt/io_graph_dialog.cpp              |   2 +-
 ui/qt/layout_preferences_frame.cpp     |  39 ++
 ui/qt/layout_preferences_frame.h       |   3 +
 ui/qt/layout_preferences_frame.ui      |  30 ++
 ui/qt/main_window.cpp                  |  44 +-
 ui/qt/main_window.h                    |   4 +-
 ui/qt/main_window.ui                   |  15 +
 ui/qt/main_window_layout.cpp           |  12 +-
 ui/qt/main_window_slots.cpp            |   6 +
 ui/qt/packet_diagram.cpp               | 736 +++++++++++++++++++++++++++++++++
 ui/qt/packet_diagram.h                 |  72 ++++
 ui/qt/tcp_stream_dialog.cpp            |   1 +
 ui/qt/utils/field_information.cpp      |  19 +-
 ui/qt/utils/field_information.h        |   1 +
 ui/qt/wireshark_application.cpp        |   8 +-
 ui/qt/wireshark_application.h          |   1 +
 ui/recent.c                            |   8 +
 ui/recent.h                            |   1 +
 30 files changed, 1037 insertions(+), 55 deletions(-)
 create mode 100644 ui/qt/packet_diagram.cpp
 create mode 100644 ui/qt/packet_diagram.h