Wireshark-commits: [Wireshark-commits] master c931f0d: Fix most remaining detected cases where item
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 8 Aug 2020 10:26:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c931f0d341d334973604a59ad8e426e4f0a183c6
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c931f0d by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    Fix most remaining detected cases where item with wrong type is used.
    
    Error: proto_tree_add_string(.., hf_ansi_a_lai_mcc, ...) called at epan/dissectors/packet-ansi_a.c:3656 with type FT_UINT8
        (allowed types are {'FT_STRINGZPAD', 'FT_STRINGZ', 'FT_STRING'} )
    
    Error: proto_tree_add_string(.., hf_ansi_a_lai_mnc, ...) called at epan/dissectors/packet-ansi_a.c:3666 with type FT_UINT8
        (allowed types are {'FT_STRINGZPAD', 'FT_STRINGZ', 'FT_STRING'} )
    
    Error: proto_tree_add_none_format(.., hf_bthci_evt_vendor_codecs_item, ...) called at epan/dissectors/packet-bthci_evt.c:4712 with type FT_UINT32
        (allowed types are {'FT_NONE'} )
    
    Error: proto_tree_add_string(.., hf_kademlia_tag_hash, ...) called at epan/dissectors/packet-edonkey.c:1100 with type FT_BYTES
        (allowed types are {'FT_STRINGZPAD', 'FT_STRINGZ', 'FT_STRING'} )
    
    Error: proto_tree_add_string(.., hf_msmms_data_timing_pair, ...) called at epan/dissectors/packet-ms-mms.c:680 with type FT_NONE
        (allowed types are {'FT_STRINGZPAD', 'FT_STRINGZ', 'FT_STRING'} )
    
    Error: proto_tree_add_float_format_value(.., hf_fp_tpc_po, ...) called at epan/dissectors/packet-umts_fp.c:2405 with type FT_UINT8
        (allowed types are {'FT_FLOAT'} )
    
    Change-Id: I1ed0276ad9c810ca6b1b01d581c3d73ae28fb9ad
    Reviewed-on: https://code.wireshark.org/review/38081
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  f5a8c08   Add FSSO (Fortinet Single Sign-On) Dissector
     add  c931f0d   Fix most remaining detected cases where item with wrong type is used.


Summary of changes:
 epan/dissectors/packet-ansi_a.c    |  4 ++--
 epan/dissectors/packet-bthci_evt.c |  4 ++--
 epan/dissectors/packet-edonkey.c   |  2 +-
 epan/dissectors/packet-ms-mms.c    | 21 +++++++++++----------
 epan/dissectors/packet-umts_fp.c   |  2 +-
 5 files changed, 17 insertions(+), 16 deletions(-)