Wireshark-commits: [Wireshark-commits] master fd03c85: check_typed_item_calls.py: Look for items wi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 8 Aug 2020 09:55:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd03c85d0f5c1e17337c2c1380e6018679f2e9c6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fd03c85 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    check_typed_item_calls.py:  Look for items with the wrong type passed to APIs
    
    Look for calls to certain proto APIs that require hf items of a certain type,
    then check that the items passed in have one of the allowed types.
    
    Currently takes around a minute to scan epan/dissectors.  There are
    a few issues that have not yet been fixed..
    
    Hopefully this can be added to the PetriDish at some point.
    
    Change-Id: Ic9eadcc3f1de03223606b5dca1cb45edcbe95e85
    Reviewed-on: https://code.wireshark.org/review/38039
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3b47a55   Replace instances of wmem_alloc with wmem_new
     add  fd03c85   check_typed_item_calls.py:  Look for items with the wrong type passed to APIs


Summary of changes:
 tools/check_typed_item_calls.py | 254 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 254 insertions(+)
 create mode 100755 tools/check_typed_item_calls.py