Wireshark · Wireshark-commits: [Wireshark-commits] master 1dd8bb2: Find and fix dissectors that should be using a default tfs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1dd8bb2811d0e3e676b61f3d7e5ac311aa8ab4fc
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1dd8bb2 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    Find and fix dissectors that should be using a default tfs.
    
    Found using tools/check_tfs.py, included in this commit.
    Here are the reports that were fixed here:
    
    Examining:
    All dissector modules
    
    epan/dissectors/packet-assa_r3.c tfs_mortisepins_flags - could have used tfs_high_low from tfs.c instead:  {High,Low}
    epan/dissectors/packet-btle.c tfs_present_bit - could have used tfs_present_not_present from tfs.c instead:  {Present,Not Present}
    epan/dissectors/packet-dhcp.c tfs_fqdn_s - could have used tfs_server_client from tfs.c instead:  {Server,Client}
    epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_on_off - could have used tfs_on_off from tfs.c instead:  {On,Off}
    epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_en_dis - could have used tfs_enabled_disabled from tfs.c instead:  {Enabled,Disabled}
    epan/dissectors/packet-docsis-macmgmt.c req_not_req_tfs - could have used tfs_requested_not_requested from tfs.c instead:  {Requested,Not Requested}
    epan/dissectors/packet-docsis-tlv.c on_off_tfs - could have used tfs_on_off from tfs.c instead:  {On,Off}
    epan/dissectors/packet-docsis-tlv.c activation_tfs - could have used tfs_active_inactive from tfs.c instead:  {Active,Inactive}
    epan/dissectors/packet-docsis.c ena_dis_tfs - could have used tfs_enabled_disabled from tfs.c instead:  {Enabled,Disabled}
    epan/dissectors/packet-ecmp.c tfs_not_expected_expected - could have used tfs_odd_even from tfs.c instead:  {Odd,Even}
    epan/dissectors/packet-erf.c erf_link_status_tfs - could have used tfs_up_down from tfs.c instead:  {Up,Down}
    epan/dissectors/packet-h263.c on_off_flg - could have used tfs_on_off from tfs.c instead:  {On,Off}
    epan/dissectors/packet-h263.c cpm_flg - could have used tfs_on_off from tfs.c instead:  {On,Off}
    epan/dissectors/packet-interlink.c flags_set_notset - could have used tfs_set_notset from tfs.c instead:  {Set,Not set}
    epan/dissectors/packet-ip.c tos_set_low - could have used tfs_low_normal from tfs.c instead:  {Low,Normal}
    epan/dissectors/packet-ip.c tos_set_high - could have used tfs_high_normal from tfs.c instead:  {High,Normal}
    epan/dissectors/packet-isakmp.c flag_r - could have used tfs_response_request from tfs.c instead:  {Response,Request}
    epan/dissectors/packet-isis-lsp.c tfs_metric_supported_not_supported - could have used tfs_no_yes from tfs.c instead:  {No,Yes}
    epan/dissectors/packet-kerberos.c supported_tfs - could have used tfs_supported_not_supported from tfs.c instead:  {Supported,Not supported}
    epan/dissectors/packet-kerberos.c set_tfs - could have used tfs_set_notset from tfs.c instead:  {Set,Not set}
    epan/dissectors/packet-mac-lte.c mac_lte_scell_status_vals - could have used tfs_activated_deactivated from tfs.c instead:  {Activated,Deactivated}
    epan/dissectors/packet-p_mul.c no_yes - could have used tfs_no_yes from tfs.c instead:  {No,Yes}
    epan/dissectors/packet-pgm.c opts_present - could have used tfs_present_not_present from tfs.c instead:  {Present,Not Present}
    epan/dissectors/packet-rsl.c rsl_ms_fpc_epc_mode_vals - could have used tfs_inuse_not_inuse from tfs.c instead:  {In use,Not in use}
    epan/dissectors/packet-sita.c tfs_sita_on_off - could have used tfs_on_off from tfs.c instead:  {On,Off}
    epan/dissectors/packet-vines.c tfs_vine_rtp_no_yes - could have used tfs_no_yes from tfs.c instead:  {No,Yes}
    epan/dissectors/packet-vnc.c button_mask_tfs - could have used tfs_pressed_not_pressed from tfs.c instead:  {Pressed,Not pressed}
    27 issues found
    Change-Id: I7e53b491f20289955c9e9caa8357197d9010a5aa
    Reviewed-on: https://code.wireshark.org/review/38087
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b711b30   netmon: handle non-monitor-mode 802.11 packets differently.
     add  1dd8bb2   Find and fix dissectors that should be using a default tfs.


Summary of changes:
 epan/dissectors/packet-assa_r3.c        |  14 +--
 epan/dissectors/packet-btle.c           |  21 ++--
 epan/dissectors/packet-dhcp.c           |   6 +-
 epan/dissectors/packet-docsis-macmgmt.c |  47 ++++-----
 epan/dissectors/packet-docsis-tlv.c     |  35 +++----
 epan/dissectors/packet-docsis.c         |  10 +-
 epan/dissectors/packet-ecmp.c           |   3 -
 epan/dissectors/packet-erf.c            |   6 +-
 epan/dissectors/packet-h263.c           |  22 ++--
 epan/dissectors/packet-interlink.c      |   7 +-
 epan/dissectors/packet-ip.c             |  18 +---
 epan/dissectors/packet-isakmp.c         |  11 +-
 epan/dissectors/packet-isis-lsp.c       |  11 +-
 epan/dissectors/packet-kerberos.c       |  27 ++---
 epan/dissectors/packet-mac-lte.c        |  66 ++++++------
 epan/dissectors/packet-p_mul.c          |   7 +-
 epan/dissectors/packet-pgm.c            |  13 +--
 epan/dissectors/packet-rsl.c            |   9 +-
 epan/dissectors/packet-sita.c           |  11 +-
 epan/dissectors/packet-vines.c          |   7 +-
 epan/dissectors/packet-vnc.c            |  20 ++--
 tools/check_tfs.py                      | 179 ++++++++++++++++++++++++++++++++
 22 files changed, 316 insertions(+), 234 deletions(-)
 create mode 100755 tools/check_tfs.py