Wireshark-commits: [Wireshark-commits] master 3b230d5: GSM A DTAP: fix the bitmask of hf_gsm_a_dtap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 2 Aug 2020 12:09:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b230d5ea3fe1bac099a50cae88b96b496c3441d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3b230d5 by Vadim Yanitskiy (vyanitskiy@xxxxxxxxxxx):

    GSM A DTAP: fix the bitmask of hf_gsm_a_dtap_test_loop
    
    According to 3GPP TS 44.014, section 8.1, type of the TCH loop is
    edcoded in bits 2..6, so we should exclude bits 1, 7, and 8.
    
    Before the patch:
    
      DTAP Tests Procedures Message Type: Close TCH Loop Cmd (0x00)
      Close TCH Loop Cmd Sub-channel
          ..00 0100 = Test Loop: C
          .... ...0 = Subchannel: Sub-channel 1 of two half rate channels is to be looped
    
    after:
    
      DTAP Tests Procedures Message Type: Close TCH Loop Cmd (0x00)
      Close TCH Loop Cmd Sub-channel
          ..00 010. = Test Loop: C
          .... ...0 = Subchannel: Sub-channel 1 of two half rate channels is to be looped
    
    Change-Id: Ie8ee23c6ce0a487d6a96b27324537372449946cb
    Reviewed-on: https://code.wireshark.org/review/37981
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2356415   libwireshark: define ENC_ANTI_HOST_ENDIAN in epan/proto.h.
     add  3b230d5   GSM A DTAP: fix the bitmask of hf_gsm_a_dtap_test_loop


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)