Wireshark-commits: [Wireshark-commits] master-3.2 77b2b84: CDP: Improve CDP port ID TLV hack heuris
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Aug 2020 10:35:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77b2b84de14274594cd3eff7db9ef59569ae4b09
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

77b2b84 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    CDP: Improve CDP port ID TLV hack heuristic
    
    The heuristic used for dissection of the port ID TLV breaks in the face
    of subsequent TLVs with tags starting with 0x10xx. This change fixes the
    heuristic to allow these new TLVs to follow the port ID TLV without
    triggering the workaround for buggy CDP senders.
    
    Bug: 16742
    Change-Id: I40c7ce790263c6de9b59ce543485cf3827f77fe7
    Reviewed-on: https://code.wireshark.org/review/37985
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 28bec58f0557f949647537d04a9dcb9dab5e5f80)
    Reviewed-on: https://code.wireshark.org/review/37986
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b04d9d4   MQ: Fix short NameValue presentation
     add  77b2b84   CDP: Improve CDP port ID TLV hack heuristic


Summary of changes:
 epan/dissectors/packet-cdp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)