Wireshark-commits: [Wireshark-commits] master c8bda07: mqtt: Do not configure a default version
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jul 2020 19:42:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8bda0764112a454709859b388e6a4d2129b8ef1
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c8bda07 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    mqtt: Do not configure a default version
    
    Do not set default version to v3.1.1, let the user set this when needed.
    Add an expert info when version is not detected.
    
    Ping-Bug: 16722
    Change-Id: Iceff83314f06510350bbe9d29cda8a239005f620
    Reviewed-on: https://code.wireshark.org/review/37928
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  9db3ce1   ascend: update a comment.
     add  c8bda07   mqtt: Do not configure a default version


Summary of changes:
 epan/dissectors/packet-mqtt.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)